Assorted improvements for TiledDataset #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #402 will not alter performanceComparing Summary
|
SolarDrew
changed the title
Cadair
force-pushed
the
tiledds-improvements
branch
from
4b8c4ed
to
6d2fff2
Compare
Cadair
force-pushed
the
tiledds-improvements
branch
from
6d2fff2
to
29a40f6
Compare
Cadair
reviewed
Jul 18, 2024
Cadair
reviewed
Jul 18, 2024
Cadair
reviewed
Jul 18, 2024
Cadair
reviewed
Jul 18, 2024
dkist/dataset/utils.py
Outdated
| wcs = ds.wcs.low_level_wcs | ||
|
|
||
| # Pixel dimensions table | ||
|
|
||
| instr = ds.meta.get("instrument_name", "") | ||
| instr = ds.inventory.get("instrument_name", "") |
There was a problem hiding this comment.
If this starting to work doesn't cause a test to fail something has gone wrong.
Suggested change
| instr = ds.inventory.get("instrument_name", "") | |
| instr = ds.inventory.get("instrument", "") |
SolarDrew
force-pushed
the
tiledds-improvements
branch
from
9fe4d14
to
3649cf1
Compare
Just uses ds[0, 0] for now for ease of putting something together. Closes DKISTDC#401
Ripped off from the one for Dataset.__repr__
SolarDrew
force-pushed
the
tiledds-improvements
branch
from
f0667d5
to
77ebde1
Compare
Cadair
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
__repr__(just uses ds[0, 0] for now for ease of putting something together). Closes #401Add
tiles_shapeproperty. Closes #403Add
slice_tiles()method to apply the same slice to all datasets. Closes #404